feat(explore-suspect-attrs): Positioning floating trigger to the bottom right #94939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdkhan14
changed the title
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #94939 +/- ##
==========================================
- Coverage 87.93% 87.88% -0.05%
==========================================
Files 10455 10449 -6
Lines 606439 604333 -2106
Branches 23550 23547 -3
==========================================
- Hits 533251 531105 -2146
- Misses 72821 72861 +40
Partials 367 367 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Chart Hook Positioning and Null Handling Errors
The useChartBoxSelect hook has three issues:
chart.getDom()is used without a null check before callinggetBoundingClientRect().- The return value of
chart.convertToPixel()is destructured without a null check, which can cause aTypeErrorif it returns null. - The
floatingTriggerPosition.leftcalculation omitswindow.scrollX, leading to incorrect positioning when the page is horizontally scrolled.
static/app/views/explore/hooks/useChartBoxSelect.tsx#L123-L136
sentry/static/app/views/explore/hooks/useChartBoxSelect.tsx
Lines 123 to 136 in 9c66878
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
|
||
| wrapper.addEventListener('mouseup', handleMouseUp); | ||
| }, [brushArea, chartWrapperRef]); | ||
| const chartRect = chart.getDom().getBoundingClientRect(); |
There was a problem hiding this comment.
iirc, getBoundingClientRect can be performance heavy. If this is for the size and position of the chart, would it be reasonable to cache this? My thinking is that having this called on every onBrushEnd might not be ideal, but this might just be nitpicking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always positioning at the bottom right prevents the trigger from covering the selected region.
Screen.Recording.2025-07-05.at.10.32.02.PM.mov